feat(bitcoin): add taproot lock output method to Script#239
Merged
matthewjablack merged 4 commits intoJul 7, 2026
Merged
Conversation
matthewjablack
approved these changes
Jul 7, 2026
matthewjablack
left a comment
Contributor
There was a problem hiding this comment.
one small nit
other than that LGTM 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Taproot scriptPubKey support for DLC output handling in
node-dlc.This PR adds a
Script.p2trLock()helper for constructing P2TR output scripts and updates DLC funding transaction change output creation to preserve rawchangeSpkscripts instead of assuming all change outputs are P2WPKH.Changes
Script.p2trLock()forOP_1 <x-only-pubkey>Taproot output scripts.Script.fromRaw()for parsing raw scriptPubKey bytes without a length prefix.BatchDlcTxBuilderto use rawchangeSpkscripts directly.Context
Previously,
BatchDlcTxBuilderrebuilt change outputs with:That only works for P2WPKH scripts and breaks for Taproot/P2TR scriptPubKeys. This is problematic when payout/liquidation addresses are Taproot and the same script is used as
changeSpk.This PR keeps DLC funding outputs unchanged as P2WSH multisig. It only makes provided output scripts round-trip correctly.
Validation
yarn buildyarn workspace @node-dlc/bitcoin testyarn workspace @node-dlc/core test -- --grep TxBuilder