feat: implement DLC splicing functionality#18
Merged
Conversation
- add DlcInputInfo struct for existing DLC funding outputs - enhance PartyParams with dlc_inputs_info field - implement CreateSplicedDlcTransactions for DLC-to-DLC transitions - add DLC input signing functions with multisig support - update fee calculation to account for DLC input weights - add comprehensive tests for splice scenarios
167fef6 to
842318e
Compare
Add validation for DLC splicing inputs including zero amount checks, pubkey validation, and dust limit enforcement. Includes extensive test coverage for all validation scenarios and edge cases. - validate DLC input amounts and pubkey uniqueness - enforce 546 sat dust limit on total input amounts - add 8 new test cases covering validation scenarios - improve error messages with party-specific context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements DLC splicing functionality that enables using existing DLC funding outputs as inputs to new DLCs
Key Features
dlc_inputs_infofield for DLC inputsSplicing Scenarios Supported
Implementation Details
Testing