feat: implement single-funded DLC transactions#16
Merged
Conversation
- add support for single-funded DLCs where one party has zero inputs - filter out dust change outputs from funding transactions - fix fee computation for single-funded DLCs with proper distribution - add comprehensive tests for single and batch single-funded DLCs - support no-change single-funded DLCs for privacy benefits
- clarify fee distribution between funding/non-funding parties - document zero input handling in fee calculation fns
aec3e7b to
abae687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements full support for single-funded DLC transactions where one party provides all inputs while the other party contributes zero inputs but still participates in the contract.
Changes Made
Single-Funded DLC Support
CreateFundTransactionandCreateBatchFundTransactionFee Distribution Logic
GetChangeOutputAndFeesfunctionsTransaction Structure Improvements
Comprehensive Testing
CreateSingleFundedDlcTransactions- Basic single-funded DLC testCreateBatchSingleFundedDlcTransactions- Batch single-funded DLC testCreateSingleFundedDlcTransactionsNoChange- No-change single-funded DLC testCreateCetTransactionNotEnoughInputTestBenefits
Use Cases
All tests pass and the implementation maintains full compatibility with existing DLC functionality.