feat: plumb contractFlags through DLC offer and transaction creation#207
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c5c21e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bennyhodl
requested changes
Jun 18, 2026
| @@ -1,5 +1,7 @@ | |||
| /* auto-generated by NAPI-RS */ | |||
|
|
|||
| export const CONTRACT_FLAG_REFUND_TO_ACCEPTER = 0x01; | |||
Collaborator
There was a problem hiding this comment.
Should this be in an autogenerated file?
- Move CONTRACT_FLAG_REFUND_TO_ACCEPTER from auto-generated ddk.ts to dlc.ts - Bump @bennyblader/ddk-ts from 0.3.31 to 0.3.39 - Remove debug console.log from BitcoinDdkProvider and BitcoinDlcProvider
bennyhodl
force-pushed
the
feat/contract-flags-refund-to-accepter
branch
from
93fe49d to
c5c21e7
Compare
bennyhodl
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plumb
contractFlagsthrough the DLC offer creation and transaction building pipeline, enablingcallers to set bit 0 (
0x01) to redirect all refund TX proceeds to the accepter (lender).Changes
CONTRACT_FLAG_REFUND_TO_ACCEPTERconstant (0x01) to@atomicfinance/typescontractFlags?: numberparameter tocreateDlcTransactionsandcreateSplicedDlcTransactionsonDdkInterfacedlcOffer.contractFlags[0]inBitcoinDdkProvider.createDlcTxsand forward to DDKBuffer.from('00', 'hex')withBuffer.from([contractFlags ?? 0x00])increateDlcOffer/batchCreateDlcOfferon both providerscontractFlagsthroughDlcProviderinterface and clientDlcclass