Improve MKCOL error handling + potential security fix#322
Open
eskimor wants to merge 1 commit intoAtalayaLabs:mainfrom
Open
Improve MKCOL error handling + potential security fix#322eskimor wants to merge 1 commit intoAtalayaLabs:mainfrom
eskimor wants to merge 1 commit intoAtalayaLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync with easysync does not work at all. It gets stuck with no further info, I did see a few error messages on the server which indicates an improper implementation of the WebDAV protocol. I fixed those and also I believe a security issue, which would allow users to create folders in folders of other users. easysync still does not work though, nevertheless filing this PR as I think it improves the status quo. I am not 100% happy, in particular passing an Option, which is always Some in production code seems unnecessary, but fixing this would be quite a bit of a refactor, which seems out of scope for a first-time contribution.
In particular, the server responds with internal server error, instead of the METHOD_NOT_ALLOWED when creating a directory that already exists.
Type of Change
Please check the option that best describes your change:
How Has This Been Tested?
I compiled & ran it on my server.
Checklist: