fix: skip empty llm summaries#8195
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider including contextual details (e.g., provider name or conversation identifier) in the warning log for empty summaries to make it easier to trace and debug in production.
- To avoid brittle coupling between the test and implementation, you could define the warning message as a constant and reference it both in
LLMSummaryCompressorand in the test assertion instead of duplicating the literal string.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider including contextual details (e.g., provider name or conversation identifier) in the warning log for empty summaries to make it easier to trace and debug in production.
- To avoid brittle coupling between the test and implementation, you could define the warning message as a constant and reference it both in `LLMSummaryCompressor` and in the test assertion instead of duplicating the literal string.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the LLMSummaryCompressor to robustly handle empty or whitespace-only responses from the LLM. It now strips the completion text and returns the original message history if the summary is empty, accompanied by a warning log. Additionally, a new test case has been added to verify this fallback behavior. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completion_textCloses #8133.
To verify
.venv\Scripts\python.exe -m py_compile astrbot\core\agent\context\compressor.py tests\agent\test_context_manager.py.venv\Scripts\python.exe -m ruff check astrbot\core\agent\context\compressor.py tests\agent\test_context_manager.py.venv\Scripts\python.exe -m pytest tests\agent\test_context_manager.py -q --basetemp .tmp\pytest -p no:cacheprovidergit diff --checkSummary by Sourcery
Handle empty LLM-generated summaries safely in the context compressor to avoid altering history when no usable summary is returned.
Bug Fixes:
Tests: