Bugfix modernbrowser#2
Merged
Merged
Conversation
removed the iPad skip use supported audio MIME types instead of forcing audio/mpeg, saving/uploading with the real file extension instead of always .mpeg.
changed version number and date in config
stop-btn wasn't working on mobile. changed hidden label to button control. also instanced variables to their respective ADC Instance ID
removed "video" from the start recording error since Microphone ADC doesnt support it
troubleshooting for mobile
changelog updated changed .catch() error to be more robust instead of "failed to record" changed stop and start record buttons to be actual button controls instead of hidden labels
removed changelog items from description CDATA. Changed author since I rewrote 70% of the current code when taking mobile browsers into account
gabrielpeter
requested changes
Apr 28, 2026
| </label> | ||
| <br/> | ||
| <audio id="player" {% if showControls Then %}controls{% Endif %} {%if notIOS then%} {% if autoplay Then %}autoplay{% Endif %} {% if loop Then %}loop{% Endif %}{%EndIf%} controlsList="nodownload"></audio> | ||
| <input |
There was a problem hiding this comment.
The more modern way of defining a button is using the button element instead of the input type="button"
| id="btnUpload_{%=CurrentADC.InstanceID%}" | ||
| class="btn" | ||
| value="{%=CurrentADC.PropValue("UploadButtonText")%}" | ||
| onclick="uploadAudio({%=CurrentADC.InstanceID%});" /> |
There was a problem hiding this comment.
The more modern way of defining a click event is using addEventListener, this is more flexible and easier to maintain
gabrielpeter
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.0.2 Microphone ADC
changed:
MIME type acception in the main script
btn-start and btn-stop behavior (removed hidden label behavior, changed to on click button events)
updated RecordRTC library to the newest version
included more robust error messaging if the control cannot or will not accept incoming audio