Correct v0.0.8 security documentation - #7
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4db38d496
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - UI listener is bound by the Entware init script to a detected private LAN address, not intentionally exposed on WAN. | ||
| - A random 256-bit administrator token is created locally with mode `0600`. | ||
| - Every state-changing request requires Bearer authentication, JSON content type and a matching browser Origin. |
There was a problem hiding this comment.
Describe Origin checks as conditional
For state-changing requests that omit Origin, sameOrigin explicitly returns true in internal/security/gate.go, and TestGateMiddleware covers an authenticated CLI request without this header. Therefore, the claim that every mutation requires a matching Origin is inaccurate and is repeated in the root SECURITY.md; clarify that browser-supplied origins are validated, or change the middleware to reject a missing header.
Useful? React with 👍 / 👎.
Summary
Validation
mainto avoid the historical squash ancestry conflict