Skip to content

Correct v0.0.8 security documentation - #7

Merged
ArtixSx merged 1 commit into
mainfrom
codex/v0.0.8-security-docs-main
Aug 12, 2026
Merged

Correct v0.0.8 security documentation#7
ArtixSx merged 1 commit into
mainfrom
codex/v0.0.8-security-docs-main

Conversation

@ArtixSx

@ArtixSx ArtixSx commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • update both security pages from prototype wording to v0.0.8-security-gate
  • document implemented Bearer/Origin/secret-redaction protections
  • keep active dataplane prerequisites explicit and clarify future cookie-session CSRF handling

Validation

  • exact documentation tree already passed both CI runs in PR Correct v0.0.8 security documentation #5
  • branch is based directly on current main to avoid the historical squash ancestry conflict
  • application code and release artifacts are unchanged

@ArtixSx
ArtixSx marked this pull request as ready for review August 12, 2026 18:26
@ArtixSx
ArtixSx merged commit 6fbb751 into main Aug 12, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4db38d496

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/SECURITY.md

- UI listener is bound by the Entware init script to a detected private LAN address, not intentionally exposed on WAN.
- A random 256-bit administrator token is created locally with mode `0600`.
- Every state-changing request requires Bearer authentication, JSON content type and a matching browser Origin.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Describe Origin checks as conditional

For state-changing requests that omit Origin, sameOrigin explicitly returns true in internal/security/gate.go, and TestGateMiddleware covers an authenticated CLI request without this header. Therefore, the claim that every mutation requires a matching Origin is inaccurate and is repeated in the root SECURITY.md; clarify that browser-supplied origins are validated, or change the middleware to reject a missing header.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant