(windows) fix window flicker when forwarding CLI args to running inst…#12
Merged
Conversation
Owner
|
It seems like the built updater no longer works. After clicking the update button, a new window flashes for a short moment, and then nothing happens. I think it silently fails at this line https://github.com/ArthurHeitmann/F-SERVO/blob/master/lib/version/installRelease.dart#L99 However the updater cli doesn't output any logs. Not sure why. 
|
Collaborator
Author
|
I added an check if the args contain flags, then we will not go into headless arg forwarding. |
Owner
|
Still the same behavior |
The updater was started via shell command string which broke when the installation path contained spaces. Now passes arguments as array directly to Process.start, which handles quoting correctly. Since shell redirection (> logfile) no longer works without runInShell, the updater now writes its own log via --log-file parameter.
Owner
|
✅ Works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ance