fix(capabilities): advertise brew alongside nix in darwin drivers list#144
Merged
Conversation
driversFor returned early after the first matching selector, so darwin advertised only "nix" even though the Homebrew driver is selectable as an additive explicit lane. Accumulate across selectBackend, selectRealizer, and selectBrewDriver so the advertised list matches what the engine can actually drive on the host. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WjiYqx7LVvR2Yr883PMKYr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping:
driversForreturned early after the first matching selector, so darwin advertised onlynixeven though the Homebrew driver is selectable as an additive explicit lane. Accumulate acrossselectBackend,selectRealizer, andselectBrewDriverso the advertised drivers list matches what the engine can actually drive on the host (darwin now advertises["nix", "brew"]).Test updated:
TestDriversFor_Darwinasserts both entries. Windows/Linux/plan9 behavior unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01WjiYqx7LVvR2Yr883PMKYr