1. Параллельное умножение матриц - #1
Open
ArtemNikit1n wants to merge 8 commits into
Open
Conversation
…mNikit1n/programming-3rd-semester into 01-concurrent-matrix-multiplication
YuriUfimtsev
approved these changes
Nov 26, 2025
|
|
||
| return (data, rows, columns); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Можно static-методы вынести в отдельный класс (/классы) для I/O операций и умножения, чтобы Matrix не перегружать
| Assert.That(() => new Matrix(TestFilePath), Throws.TypeOf<FormatException>()); | ||
| Assert.That(() => new Matrix(File.OpenRead(TestFilePath)), Throws.TypeOf<FormatException>()); | ||
| Assert.That(() => new Matrix(new MemoryStream(contentBytes)), Throws.TypeOf<FormatException>()); | ||
| } |
There was a problem hiding this comment.
Github описал этот файл как large diffs :)
Тесты тоже хорошо бы по нескольким файлам разнести: например, тесты инициализации матрицы через конструкторы, тесты на умножение, тесты на сохранение в файл и чтение матрицы из него
|
|
||
| using ConcurrentMatrixMultiplication; | ||
|
|
||
| if (args.Length >= 3) |
There was a problem hiding this comment.
Suggested change
| if (args.Length >= 3) | |
| if (args.Length < 3) | |
| { | |
| Console.WriteLine("Usage: dotnet run -- <left_matrix> <right_matrix> <result> [--sequential|--parallel]"); | |
| Console.WriteLine("Examples:"); | |
| Console.WriteLine(" dotnet run -- matrix1.txt matrix2.txt result.txt --parallel"); | |
| Console.WriteLine(" dotnet run -- matrix1.txt matrix2.txt result.txt --sequential"); | |
| return; | |
| } |
Лучше так, чтобы не создавать лишней вложенности
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.