Feature/contextbridge exposeinmainworld#34
Open
Arroquw wants to merge 5 commits into
Open
Conversation
Collaborator
|
When I test this, what does it do exactly? I'm unfamiliar with this feature. |
Owner
Author
|
The main takeaway here is security changes and the TODO that skillbert left. Basically it should work exactly as before, but now we're using isolated contexts, meaning that the renderer window has no access to the other windows' JS for instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
took a lot of fiddling and a bit of vibe coding to get this working. Probably needs a lot of refactoring, but in this state it works.
Tested with clue trainer, clue solver
Also, a lot of plugins rely on setting window.alt1.events, so converting it as is to use
exposeInMainWorldwas impossible, since that makes the entire window.alt1 object immutable. I opted for a hybrid approach, but there's probably better solutions that I don't know of?Fixes #30