Change conventions for host/subhalo weighting in weighted_lc function#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes our conventions for the weights that get attached to subhalo lightcones by the
weighted_lcfunction. There are two new field names:As a result of this PR, there is a new way to compute weighted histogram results with twndhist and signdhist. The weights that should be used for histograms are now:
Note that this is different from #37. This PR supersedes #37.
The diffsky PR ArgonneCPAC/diffsky#416 establishes successful CI testing against the code in this PR. So we can proceed to merge this in, do a new minor release of
diffhalos, and then merge ArgonneCPAC/diffsky#416 into diffsky, and finally do a new release of diffsky.