🍎 tests: release UDP port between MAVFTP tests#1219
Merged
Conversation
TestMAVFTPPayloadDecoding.setUp() opens a udp:localhost:14550 connection for every test but tearDown() never closed it. Re-binding the port in the next setUp() works on Linux (SO_REUSEADDR) but fails on macOS with 'Address already in use'. Close the connection in tearDown().
drnic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestMAVFTPPayloadDecoding.setUp()opens audp:localhost:14550connection for every test, buttearDown()never closed it. Re-binding the same port in the next test'ssetUp()succeeds on Linux (the socket setsSO_REUSEADDR) but fails on macOS withOSError: [Errno 48] Address already in use, since macOS additionally requiresSO_REUSEPORTto rebind.This makes the test suite fail for anyone running it on macOS, while passing in CI (Linux).