fix(wlua): handle signed MAVLink v2 packets in Wireshark dissector#1211
Open
g-ampo wants to merge 1 commit into
Open
fix(wlua): handle signed MAVLink v2 packets in Wireshark dissector#1211g-ampo wants to merge 1 commit into
g-ampo wants to merge 1 commit into
Conversation
tridge
approved these changes
May 18, 2026
Add bounds check before reading 13-byte signature block to prevent Lua runtime errors on truncated buffers (e.g. USB bulk transfer fragmentation). Use bit.band() for incompat flag check per MAVLink spec bitmask semantics. Fixes ArduPilot#1178.
g-ampo
force-pushed
the
fix/wireshark-signed-packet-dissection
branch
from
f40dd48 to
9543ba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1178.
The signature parsing block in generated Lua dissector reads
buffer(offset,1)w/out checking remaining length.On truncated buffers, this throws a Lua
Range is out of boundserror that kills the dissector for the entire capture, so guard withoffset + 13 <= buffer:len()before reading the 13-byte signature. Also usebit.band()instead of== 0x01for the incompat flag . MAVLink spec (bitmask field).