generator/C: clamp asin argument in mavlink_dcm_to_euler#1208
Open
g-ampo wants to merge 1 commit into
Open
Conversation
Author
|
@peterbarker @tridge could you review this when you have a moment? It resolves the NaN pitch bug reported in mavlink/mavlink#2389 cc @DonLakeFlyer - A fix for your issue is ready for testing here. |
tridge
approved these changes
May 18, 2026
FP rounding in mavlink_quaternion_to_dcm can push dcm[2][0] outside [-1, 1], making asin return NaN. Mirrors the clamp in pymavlink/quaternion.py. Refs: mavlink/mavlink#2389
g-ampo
force-pushed
the
fix/2389-clamp-asin-pitch
branch
from
269d694 to
71179f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes mavlink/mavlink#2389.
asin(-dcm[2][0])returns NaN when FP rounding pushes the argument outside [-1, 1]. Clamps the argument in both v1.0 and v2.0 helpers, matching the existing clamp inpymavlink/quaternion.py.