setup: build fast indexer iff Cython available#1187
Open
robertlong13 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I have tested on Windows with a venv without cython installed. I just realized that I wasn't seeing the warning though. Turns out pip swallows any output from setup.py here, and there's not a way around it as far as I can tell. I can drop the warning if anyone wants, since it's not functional (except by someone running setup.py directly) (edit: actually, I'm just gonna strip it out, even if nobody wants me to) |
robertlong13
force-pushed
the
pr/fast-indexer-default-off-more
branch
from
06961c5 to
7c41a4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to off for everyone unless they have everything needed to build it.
This never needed to be this complicated. There was an assumption that everyone on Linux, building pymavlink from source, would want fast indexing, but that was a little silly from the start.