Skip to content

.github: avoid use of pull_request_target#33086

Merged
peterbarker merged 1 commit into
ArduPilot:masterfrom
peterbarker:pr/no-pr-target
May 19, 2026
Merged

.github: avoid use of pull_request_target#33086
peterbarker merged 1 commit into
ArduPilot:masterfrom
peterbarker:pr/no-pr-target

Conversation

@peterbarker

Copy link
Copy Markdown
Contributor

Summary

Stop using pull_request_target in our github workflows.

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

Description

this is starting to get a very bad name in terms of security vulnerability.

It is not clear why this required pull_request_target

this is starting to get a very bad name in terms of security vulnerability.

It is not clear why this required pull_request_target
@peterbarker

peterbarker commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Unfortunately things don't get tagged when not pull_request_target: peterbarker#43

.... it actually did get labelled!

@peterbarker peterbarker moved this to ReadyForDevCall in Peter's ArduPilot 4.8 Queue May 17, 2026

@khancyr khancyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 5186324 into ArduPilot:master May 19, 2026
110 of 113 checks passed
@github-project-automation github-project-automation Bot moved this from ReadyForDevCall to Done in Peter's ArduPilot 4.8 Queue May 19, 2026
@peterbarker peterbarker deleted the pr/no-pr-target branch May 19, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants