Fix SSR PostGraphile access for Next 15 dev#41
Merged
Conversation
Next 15 dev wraps page requests in a Proxy. Accessing `req.app` through
that wrapper can interact badly with Express because the Express app is
both a callable function and an object with route helpers. In practice,
our SSR Apollo setup could end up tripping Express path handling with a
non-string value, causing:
TypeError: path.replace is not a function
during `getDataFromTree`.
Read the PostGraphile instance from the Express app once while installing
SSR, then attach it directly to each SSR request as `req.pgl`. The
server-side Apollo link now reads `req.pgl` instead of reaching back
through `req.app.get("pgl")` during page rendering.
This keeps SSR independent of Next's request proxy behavior and avoids
accidentally invoking Express routing internals while building the
server-side GraphQL link.
AprilArcus
force-pushed
the
pass-pgl-on-req
branch
from
b05c866 to
b4102e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next 15 dev wraps page requests in a Proxy. Accessing
req.appthrough that wrapper can interact badly with Express because the Express app is both a callable function and an object with route helpers. In practice, our SSR Apollo setup could end up tripping Express path handling with a non-string value, causing:TypeError: path.replace is not a function
during
getDataFromTree.Read the PostGraphile instance from the Express app once while installing SSR, then attach it directly to each SSR request as
req.pgl. The server-side Apollo link now readsreq.pglinstead of reaching back throughreq.app.get("pgl")during page rendering.This keeps SSR independent of Next's request proxy behavior and avoids accidentally invoking Express routing internals while building the server-side GraphQL link.