fix: build production packages from release branch instead of master#422
Closed
Kobikg78 wants to merge 1 commit into
Closed
fix: build production packages from release branch instead of master#422Kobikg78 wants to merge 1 commit into
Kobikg78 wants to merge 1 commit into
Conversation
Backport releases (e.g. 6.17.x while master is on 6.18.x) require the build to use the release branch content, not master. Also tags and reads SDK version info from the release branch for correct Slack notifications. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build-Production-Packagesnow checks outRELEASE_BRANCH_NAMEinstead ofmasterGenerate-Tagnow tags the release branch HEAD instead of masternotify-teamSlack step reads SDK versions from the release branchWhy
Backport releases (e.g. 6.17.900 while master is at 6.18.x) were building from master, producing a package with the wrong SDK versions. This also caused
Generate-Tagto tag the wrong commit.Test plan
workflow_dispatchon release 6.17.900 — verify it checks out the release branch and builds correct SDK versions🤖 Generated with Claude Code