Conversation
The mkdoc_annotation _snippets definition (added in #868) breaks CloudCannon's Rich Text editor with 'Failed to process the current value' on every page. Unlike the working button snippets, which are single-line inline templates, the annotation template spans multiple blocks (paragraph + { .annotate } attribute + ordered list). CloudCannon builds a matcher from every snippet template and runs it against the whole page on load, and it cannot compile this block-spanning template, so processing throws even on pages with no annotations. No documentation page uses the annotation syntax, so removing the definition loses no content. This reverts cloudcannon.config.yml to the last known-good state (9cd1310), which the CloudCannon GUI was able to edit. Annotations can still be authored in CloudCannon's source mode.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Routine
dev → mainsync to publish the latest docs to the live wiki. Rolls up the merged work ondev, including the CloudCannon Rich Text editor fix (#877) and the ESPHome Starter Kit FAQ page (#875).Types of changes
mkdocs.yml)Checklist:
devbranch (notmain)mkdocs servemkdocs.ymlmkdocs.yml