Skip to content

Fix firmware update system (404 manifest URL, stale first check)#26

Open
bharvey88 wants to merge 2 commits into
betafrom
fix-update-system
Open

Fix firmware update system (404 manifest URL, stale first check)#26
bharvey88 wants to merge 2 commits into
betafrom
fix-update-system

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

While rolling the R_PRO-1 managed update system out to other devices we audited every repo's manifest URLs, and H-1's is broken in production:

Fixes

  • The Firmware Update entity has never worked: it points at https://apolloautomation.github.io/H-1/artifact/manifest.json, which is a 404 — CI publishes to /H-1/firmware/manifest.json (200). Devices fail every check with ESP_ERR_HTTP_CONNECT-style errors and show "up to date" forever.
  • Manifest check on WiFi connect: the update component's first 6-hour poll fires before the network is up and skips silently, so even with the URL fixed the entity would be stale for ~6h after every boot. Added component.update: firmware_update to the existing wifi.on_connect automation.
  • firmare-dfirmware-d typo in the H-1D publish directory name. Nothing references the misspelled path today (H-1D has no update entity), so the rename is safe.

Not included

H-1D has no update entity at all. It's a deep-sleep battery device (prevent-sleep defaults off), so giving it the update system means deciding the wake/check policy — left for a separate discussion. Once added it should point at the (now correctly spelled) firmware-d manifest.

H-1.yaml compile-verified on ESPHome 2026.1.3.

- The Firmware Update entity pointed at /H-1/artifact/manifest.json,
  which is a 404 (CI publishes to /H-1/firmware/) - the update system
  has never been able to offer an update
- Trigger a manifest check once WiFi connects: the update component's
  first 6h poll fires before the network is up and skips silently,
  leaving the entity stale for ~6h after every boot
- Fix firmare-d -> firmware-d typo in the H-1D publish directory
@bharvey88 bharvey88 added the bugfix Bug fix label Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@TrevorSchirmer, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 052ecc64-e983-4385-b907-52073b0d6157

📥 Commits

Reviewing files that changed from the base of the PR and between 36b029e and c1c9e8f.

📒 Files selected for processing (3)
  • .github/release-drafter.yml
  • .github/workflows/build.yml
  • Integrations/ESPHome/H-1.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-update-system

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Home Assistant shows only the first 255 characters of an ESPHome
release summary, so boilerplate is expensive and ## headings render
oversized in the update dialog:

- Render category titles and What's Changed in bold instead of H2
- Drop the star-the-repo footer
- Drop the Full Changelog line: it semver-truncates 4-part versions
  (always links ...X.Y.Z.1) - the shared build workflow now appends
  a correct compare link instead
@bharvey88 bharvey88 force-pushed the fix-update-system branch from ea10fac to c1c9e8f Compare June 11, 2026 14:40
@TrevorSchirmer

Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants