Fix Apollo Firmware Version sensor blank on factory/BLE firmware#96
Fix Apollo Firmware Version sensor blank on factory/BLE firmware#96bharvey88 wants to merge 1 commit into
Conversation
The on_boot publish for apollo_firmware_version was only added to AIR-1.yaml (b5096d4), but the published firmware is built from AIR-1_Factory.yaml, and AIR-1_BLE.yaml was also missed. Devices running shipped firmware never publish the text sensor state, so it shows blank in HA and the web portal even though device info shows the project version. Add the same priority-500 on_boot publish to both files and bump the version so devices are offered the fixed build. Fixes #93
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe PR bumps the firmware version substitution from 26.3.2.1 to 26.6.10.1 and configures both AIR-1 device configurations to publish a template text sensor ( ChangesFirmware Version Publishing on Boot
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Version: 26.6.10.1
Adds:
Fixes:
on_bootpublish added in Release 26.3.2.1 - New sensors, ESPHome modernisation, and bug fixes #89 only went intoAIR-1.yaml, but the published firmware is built fromAIR-1_Factory.yaml(seebuild.yml), andAIR-1_BLE.yamlwas also missed. This adds the same priority-500text_sensor.template.publishto both files, matching the pattern already used in MSR-2's factory config.Breaks:
Checks:
Verified with
esphome config(2026.1.3): all three configs validate, and the merged Factory/BLE output now contains theon_bootpublish with state26.6.10.1.Summary by CodeRabbit
New Features
Chores