Skip to content

Fix Apollo Firmware Version sensor blank on factory/BLE firmware#96

Open
bharvey88 wants to merge 1 commit into
mainfrom
fix/factory-firmware-version
Open

Fix Apollo Firmware Version sensor blank on factory/BLE firmware#96
bharvey88 wants to merge 1 commit into
mainfrom
fix/factory-firmware-version

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Version: 26.6.10.1

Adds:

Fixes:

Breaks:

  • Nothing

Checks:

  • Documentation Updated
  • Build Number Incremented In AIR-1.yaml

Verified with esphome config (2026.1.3): all three configs validate, and the merged Factory/BLE output now contains the on_boot publish with state 26.6.10.1.

Summary by CodeRabbit

  • New Features

    • Firmware version is now automatically published and accessible as a sensor on device startup.
  • Chores

    • Updated system firmware version to 26.6.10.1.

The on_boot publish for apollo_firmware_version was only added to
AIR-1.yaml (b5096d4), but the published firmware is built from
AIR-1_Factory.yaml, and AIR-1_BLE.yaml was also missed. Devices
running shipped firmware never publish the text sensor state, so it
shows blank in HA and the web portal even though device info shows
the project version.

Add the same priority-500 on_boot publish to both files and bump the
version so devices are offered the fixed build.

Fixes #93
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 30b56fa4-7433-45a8-ba36-bb6626ba48e9

📥 Commits

Reviewing files that changed from the base of the PR and between 025e0f7 and 65d7fae.

📒 Files selected for processing (3)
  • Integrations/ESPHome/AIR-1_BLE.yaml
  • Integrations/ESPHome/AIR-1_Factory.yaml
  • Integrations/ESPHome/Core.yaml

Walkthrough

The PR bumps the firmware version substitution from 26.3.2.1 to 26.6.10.1 and configures both AIR-1 device configurations to publish a template text sensor (apollo_firmware_version) on boot, setting its state to the updated version variable.

Changes

Firmware Version Publishing on Boot

Layer / File(s) Summary
Version substitution update
Integrations/ESPHome/Core.yaml
Version substitution changed to 26.6.10.1, which is then referenced by the device boot sequences.
Firmware version sensor on boot
Integrations/ESPHome/AIR-1_BLE.yaml, Integrations/ESPHome/AIR-1_Factory.yaml
Both configurations add text_sensor.template.publish action in the on_boot sequence to publish apollo_firmware_version with state set to ${version}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ApolloAutomation/AIR-1#88: Refactors firmware-version sensor publishing to occur once on boot with the same text_sensor.template.publish pattern and ${version} substitution.
  • ApolloAutomation/AIR-1#89: Implements the same on_boot text_sensor.template.publish action for apollo_firmware_version with state: "${version}" across device configurations.
  • ApolloAutomation/AIR-1#72: Also updates substitutions.version in Core.yaml to a newer release identifier.

Suggested labels

bugfix

Suggested reviewers

  • TrevorSchirmer

Poem

🐰 A firmware version awakens,
Published on boot with care,
Core whispers its number true—
Both devices now declare,
26.6.10.1 in the air! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: adding the Apollo Firmware Version sensor publish action to factory/BLE firmware configurations to resolve the blank sensor issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/factory-firmware-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Air-1 Firmware Version Data Not Appearing

1 participant