Skip to content

refactor(hir): audit #[allow(dead_code)] stubs in cssl-hir #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmchow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(hir): audit #[allow(dead_code)] stubs in cssl-hir #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions compiler-rs/crates/cssl-hir/src/cap_check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,14 @@ impl CapCtx {
}
}

#[allow(dead_code)] // reserved for T3.4-phase-2.5 expression walk
// Reserved for the deferred T3.4-phase-2.5 body-walk slice of cap_check.
// The signature-level minimum-viable check landed in DECISIONS.md § T5-D3
// (Cap-check pass sig-level only for stage-0 ; full expr walk deferred),
// which explicitly defers "full linear-use tracking through every
// expression" + "handler-one-shot enforcement" to T3.4-phase-2.5. This
// helper will be wired in when that slice lands; until then, cargo
// -D warnings needs the allow.
#[allow(dead_code)] // T5-D3: wired in at T3.4-phase-2.5
fn emit(&mut self, message: impl Into<String>, span: Span) {
self.diagnostics
.push(Diagnostic::error(message).with_span(span));
Expand Down Expand Up @@ -228,7 +235,10 @@ impl CapCtx {
}
}

#[allow(dead_code)] // reserved for T3.4-phase-2.5 expression walk
// See `emit` above for the DECISIONS.md § T5-D3 tracking note -- matrix() is
// the AliasMatrix accessor the deferred T3.4-phase-2.5 body-walk needs to
// run `AliasMatrix::can_pass_through`/`param_subtype_check` at call sites.
#[allow(dead_code)] // T5-D3: wired in at T3.4-phase-2.5
fn matrix(&self) -> &AliasMatrix {
&self.matrix
}
Expand Down
5 changes: 1 addition & 4 deletions compiler-rs/crates/cssl-hir/src/lower.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
//! `HirExprKind::Compound` with the operator-class preserved.

use cssl_ast::cst;
use cssl_ast::{DiagnosticBag, Ident, Module as CstModule, SourceFile, Span};
use cssl_ast::{DiagnosticBag, Ident, Module as CstModule, SourceFile};

use crate::arena::{DefId, HirArena, HirId};
use crate::attr::{HirAttr, HirAttrArg, HirAttrKind};
Expand Down Expand Up @@ -1267,9 +1267,6 @@ fn resolve_struct_body(b: &mut HirStructBody, scope: &ScopeMap) {
}
}

/// Hide the empty Span+SourceFile re-export so the `Span` import doesn't show as unused.
#[allow(dead_code)]
const fn _span_referenced(_: Span) {}

#[cfg(test)]
mod tests {
Expand Down