fix(router): make off() unsubscribe handlers correctly + refactor + docs#19
Merged
Conversation
added 8 commits
April 28, 2026 10:49
Derive router event names from a single typed tuple and update off() to assign a filtered handler list so unsubscribe works as intended. Remove obsolete array helpers and extend router tests to cover handler removal and invalid event-name guard behavior.
Add an agent-oriented lint entrypoint and repository guidance so automated contributors run consistent post-edit checks. Update Cursor skill/rule docs to match the current biome+prettier flow and include an AGENTS.md onboarding guide.
Apply formatting cleanup to changelog and website docs assets to keep generated and authored documentation consistent. This reduces noisy diffs and keeps style updates aligned with the lint-agent workflow.
Use string[] for splitPathReducer accumulator to remove an unnecessary any and keep utility typing explicit.
Unify Router, React components, and plugins around named exports while removing deep lib/esm subpath exports from package metadata. Update tests and docs to consume root-level named imports so usage stays consistent with the supported public API. BREAKING CHANGE: default exports and deep subpath imports (e.g. bard-router/lib/* and bard-router/esm/*) are no longer part of the public API; import from bard-router using named exports.
Update README copy to reflect the current typed API, simplify installation instructions, and add a root-level named import usage example. Align build notes with the current package export surface by removing outdated deep-import wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.