Refactor Initial Analysis and Related Doctypes - #9
Merged
Merged
Conversation
- Updated form event handlers in `FormEvents.ts` for `checklist_of_datalogger` to improve field management and data retrieval. - Removed references to `inanly_docname` in `checklist_of_ev_charger`, `checklist_of_inverter`, `checklist_of_smart_energy_manager`, and `checklist_of_smart_meter` JSON files, replacing them with `ticket_docname` for consistency. - Enhanced `fields_handler` functions in `checklist_of_inverter` and `checklist_of_datalogger` to utilize `get_target_field_by_field_match` for fetching values from related doctypes. - Adjusted the creation of Serial No documents in `initial_analysis.js` to use `ticket_docname` instead of `inanly_docname`. - Cleaned up JSON definitions across multiple checklists to remove unnecessary fields and ensure proper linkage to the ticketing system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormEvents.tsforchecklist_of_dataloggerto improve field management and data retrieval.inanly_docnameinchecklist_of_ev_charger,checklist_of_inverter,checklist_of_smart_energy_manager, andchecklist_of_smart_meterJSON files, replacing them withticket_docnamefor consistency.fields_handlerfunctions inchecklist_of_inverterandchecklist_of_dataloggerto utilizeget_target_field_by_field_matchfor fetching values from related doctypes.initial_analysis.jsto useticket_docnameinstead ofinanly_docname.