Skip to content

L10n update #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odie2 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

L10n update #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e81ea1
Seems like it's too early to translate options page string.
odie2 Jun 25, 2015
403c4f1
`Settings` is global phrase used exactly in this place.
odie2 Jun 25, 2015
9423f72
$this->textdomain seems like broken.
odie2 Jun 25, 2015
6e0c7c4
Added "Apply to text widgets" phrase to .pot (manually).
odie2 Jun 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class BJLL_Admin_Page extends scbAdminPage {
function setup() {
$this->args = array(
'menu_title' => 'BJ Lazy Load',
'page_title' => __( 'BJ Lazy Load Options', 'bj-lazy-load' ),
'page_title' => 'BJ Lazy Load Options',
);
}

Expand Down
4 changes: 4 additions & 0 deletions lang/bj-lazy-load.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ msgid "No"
msgstr ""

#: admin.php:23
msgid "Apply to text widgets"
msgstr ""

#: admin.php:29
msgid "Apply to post thumbnails"
msgstr ""

Expand Down
14 changes: 7 additions & 7 deletions scb/AdminPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function page_help(){}
function page_header() {
echo "<div class='wrap'>\n";
screen_icon( $this->args['screen_icon'] );
echo html( 'h2', $this->args['page_title'] );
echo html( 'h2', __( $this->args['page_title'], 'bj-lazy-load' ) );
}

/**
Expand Down Expand Up @@ -224,7 +224,7 @@ function form_handler() {
*/
function admin_msg( $msg = '', $class = 'updated' ) {
if ( empty( $msg ) )
$msg = __( 'Settings <strong>saved</strong>.', $this->textdomain );
$msg = __( 'Settings <strong>saved</strong>.', 'bj-lazy-load' );

echo scb_admin_notice( $msg, $class );
}
Expand Down Expand Up @@ -409,7 +409,7 @@ function page_init() {
if ( ! $this->args['toplevel'] ) {
$this->pagehook = add_submenu_page(
$this->args['parent'],
$this->args['page_title'],
__( $this->args['page_title'], 'bj-lazy-load' ),
$this->args['menu_title'],
$this->args['capability'],
$this->args['page_slug'],
Expand All @@ -418,7 +418,7 @@ function page_init() {
} else {
$func = 'add_' . $this->args['toplevel'] . '_page';
$this->pagehook = $func(
$this->args['page_title'],
__( $this->args['page_title'], 'bj-lazy-load' ),
$this->args['menu_title'],
$this->args['capability'],
$this->args['page_slug'],
Expand All @@ -429,7 +429,7 @@ function page_init() {

add_submenu_page(
$this->args['page_slug'],
$this->args['page_title'],
__( $this->args['page_title'], 'bj-lazy-load' ),
$this->args['submenu_title'],
$this->args['capability'],
$this->args['page_slug'],
Expand Down Expand Up @@ -463,7 +463,7 @@ private function check_args() {
'menu_title' => $this->args['page_title'],
'page_slug' => '',
'nonce' => '',
'action_link' => __( 'Settings', $this->textdomain ),
'action_link' => 'Settings',
'admin_action_priority' => 10,
) );

Expand Down Expand Up @@ -511,7 +511,7 @@ function _page_content_hook() {
function _action_link( $links ) {
$url = add_query_arg( 'page', $this->args['page_slug'], admin_url( $this->args['parent'] ) );

$links[] = html_link( $url, $this->args['action_link'] );
$links[] = html_link( $url, __( $this->args['action_link'] ) );

return $links;
}
Expand Down