Skip to content

GUI: Fix build on clang++ #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyFilter merged 3 commits into from
Apr 17, 2026
Merged

GUI: Fix build on clang++ #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c069ab9
gui: Allow overriding the compiler (`CXX`)
delet-this Apr 15, 2026
bad1f81
gui: Add missing includes
delet-this Apr 15, 2026
3326f08
gui: Silence warnings for ImGui/ImPlot
delet-this Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gui/ConfigHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
#define GUI_CONFIGHELPER_H

#include <optional>
#include <sstream>
#include <string>
#include "DriverHelper.h"

namespace ConfigHelper {
Expand Down
2 changes: 2 additions & 0 deletions gui/CustomCurve.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "CustomCurve.h"

#include <algorithm>
#include <sstream>
#include <string>
#include <vector>

#include "DriverHelper.h"
Expand Down
12 changes: 10 additions & 2 deletions gui/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# Define the compiler and flags
CXX = g++
CXX ?= g++
CXXFLAGS = -std=c++17 -I . -isystem External

# ImPlot has few of these
IMGUIFLAGS = -Wformat=0 -Wno-format-security
ifneq (,$(findstring clang,$(CXX)))
# ImGui produces many of these
IMGUIFLAGS += -Wno-nontrivial-memcall
endif

WARNFLAGS = -Wall -Wno-sign-compare
OPTIMIZATION_FLAGS = -O2 -flto=auto
DEBUG_FLAGS = -g -O0
Expand Down Expand Up @@ -45,7 +53,7 @@ $(TARGET): $(OBJECTS)

# Rule to build the object files for ImGui source files
External/ImGui/%.o: External/ImGui/%.cpp
$(CXX) $(CXXFLAGS) $(GLFW_CFLAGS) $(OPTIMIZATION_FLAGS) -c $< -o $@
$(CXX) $(CXXFLAGS) $(GLFW_CFLAGS) $(OPTIMIZATION_FLAGS) $(IMGUIFLAGS) -c $< -o $@

.PHONY: all check_deps clean clean-all debug

Expand Down
Loading