Remove duplicate CI workflow, consolidate pipeline#9
Merged
Conversation
ci.yml and main-ci.yml both triggered on push to main, causing duplicate pipeline runs. Removed ci.yml entirely since main-ci.yml already contains the same CI stages. Added the WASM client build check (the only step main-ci.yml was missing) to the consolidated pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…lict The self-hosted runner often has a dev breakpoint-server on port 8080. The CI pipeline previously killed it with pkill and reused the port, which is fragile and disruptive. Now: - CI server listens on port 9090 via BREAKPOINT_LISTEN_ADDR - Early port-availability check fails fast if 9090 is taken - Server stopped by PID file instead of pkill (no collateral damage) - Playwright config and helpers respect BASE_URL env var - Hardcoded ws://127.0.0.1:8080/ws in shared.js now derived from BASE_URL Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml-- it triggered onpush: branches: [main]and ran the exact same CI stages (fmt, clippy, test, build, cargo-deny) thatmain-ci.ymlalready runs, causing two redundant pipeline runs on every push to main.main-ci.yml's CI job -- this was the only step inci.ymlthatmain-ci.ymlwas missing.CLAUDE.mdto document the simplified two-workflow pipeline.Before
ci.yml+main-ci.yml(duplicate CI)ci.yml+main-ci.ymlpr-validation.ymlAfter
main-ci.yml(CI only, release stages skipped)main-ci.yml(CI + Docker + release builds + GitHub Release)pr-validation.ymlTest plan
main-ci.ymlruns on push to main with CI stages only (no release/docker)Generated with Claude Code