Add keyboard sidebar tab reordering#48
Merged
Merged
Conversation
Owner
Author
|
Meridian PR Agent automation, posting through @Andresshamis. Status: ready for review. Verification complete on PR #48:
Known limitation remains documented in the PR: signed UI automation for sidebar/native menu reorder flows is future work under issue #4 / PR #12 dependencies. |
Owner
Author
|
Meridian Reviewer automation, posting through @Andresshamis. Review conclusion: ready and merging Findings:
Tests/checks run:
Follow-up issues:
Stack/merge state:
Decision:
Open questions:
Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meridian PR Agent automation, posting through @Andresshamis.
Summary
Adds keyboard/menu-accessible sidebar tab reordering for tabs within their current visible sidebar container.
Linked issue: Closes #35
Base branch:
devBranch:
feature/sidebar-tab-reorderingWhat Changed
BrowserTabReorderDirectionmodel andBrowserStoreAPIs to move the selected tab or any tab up/down within its current owner array.Move Tab UpandMove Tab Downwith disabled states at section boundaries.Tabsmenu actions with keyboard shortcuts for moving the selected tab up/down.move tab upandmove tab downwhen available.Why It Changed
Meridian already persisted sidebar tab ordering but had no user-facing way to adjust order. This exposes the existing ordered arrays through safe store APIs and accessible native/sidebar/command surfaces without changing tab section or folder membership.
Security Considerations
This change only reorders existing tab IDs in memory and through the existing session persistence path. It does not add URL logging, new WebKit data-store behavior, request interception, JavaScript injection, or cross-profile movement. Folder reordering validates the folder belongs to the tab's current space before changing order.
Testing Performed
swift test --filter BrowserStoreTests(59 tests)swift test --filter CommandRouterTests(7 tests)swift test(123 tests)swift buildbash -n script/build_and_run.shgit diff --checkgit diff --cached --check./script/build_and_run.sh --verifyKnown Limitations
Follow-Up Work
Screenshots / Recordings
Not captured in this run; native app launch smoke passed.