Skip to content

Reset transcript on startListening#1

Open
rjbtechconsult wants to merge 2 commits into
Amin-Partovi:mainfrom
rjbtechconsult:main
Open

Reset transcript on startListening#1
rjbtechconsult wants to merge 2 commits into
Amin-Partovi:mainfrom
rjbtechconsult:main

Conversation

@rjbtechconsult

Copy link
Copy Markdown

Reset transcript on startListening() so that new transcripts will not be appended to the old transcript when the user starts a new speech

rjbtechconsult and others added 2 commits February 15, 2024 10:06
Reset transcript so that new transcripts will not be appended to old …
@Amin-Partovi

Copy link
Copy Markdown
Owner

Thank you for the contribution, it will be reviewed ASAP

@Amin-Partovi

Copy link
Copy Markdown
Owner

@rjbtechconsult I reviewed your PR, I think it's better to implement one of these two scenarios:

  1. adding reset() handler to remove the transcript instead of startListening.
  2. adding pauseListening() and resumeListening() handlers and clean the transcript on startListening().

@rjbtechconsult

rjbtechconsult commented Feb 16, 2024

Copy link
Copy Markdown
Author

That is a good idea. There also need to be a handler to check if listening is on or off (this can be used to conditionally trigger some views on the UI.

@Amin-Partovi

Copy link
Copy Markdown
Owner

That is a good idea. There also need to be a handler to check if listening is on or off (this can be used to conditionally trigger some views on the UI.

yeah, useTextToVoice hook returns a boolean isSpeaking, we can also have a similar boolean that shows the listening is on or off fo the useVoiceToText hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants