fix: resolve 5 SonarQube code quality issues

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Eliminates ambiguous method overload resolution and removes unnecessary static constructors by inlining static field initializations. These changes improve code clarity and reduce unnecessary performance overhead from compiler-generated static constructor checks.

View Project in SonarCloud

---

Fixed Issues

csharpsquid:S3220 - Review this call, which partially matches an overload without 'params'. The partial match is 'string[] string.Split(char separator, int count, StringSplitOptions options = StringSplitOptions.None)'. • MINOR • View issue

Location: src/Cake.Common/Tools/NuGet/List/NuGetList.cs:77

Why is this an issue?

The rules for method resolution are complex and perhaps not properly understood by all coders. The params keyword can make method declarations overlap in non-obvious ways, so that slight changes in the argument types of an invocation can resolve to different methods.

What changed

This hunk fixes the ambiguous method resolution warning on string.Split. The original call line.Split(' ', '\t') with two char arguments partially matches the overload string.Split(char separator, int count, StringSplitOptions options) because the second char could be implicitly converted to int. By changing the call to line.Split(new[] { ' ', '\t' }, StringSplitOptions.None), the invocation now explicitly targets the Split(char[], StringSplitOptions) overload, eliminating the ambiguity between the params-based overload and the non-params overload.

--- a/src/Cake.Common/Tools/NuGet/List/NuGetList.cs
+++ b/src/Cake.Common/Tools/NuGet/List/NuGetList.cs
@@ -77,1 +77,1 @@ namespace Cake.Common.Tools.NuGet.List
-            var splitline = line.Split(' ', '\t');
+            var splitline = line.Split(new[] { ' ', '\t' }, StringSplitOptions.None);

csharpsquid:S3963 - Initialize all 'static fields' inline and remove the 'static constructor'. • MINOR • View issue

Location: src/Cake.Common/Tools/Cake/CakeRunner.cs:34

Why is this an issue?

When a static constructor serves no other purpose that initializing static fields, it comes with an unnecessary performance cost because the compiler generates a check before each static method or instance constructor invocation.

What changed

This hunk inlines the initialization of the static field _executingAssemblyToolPaths by assigning it directly at the declaration site via a helper method GetExecutingAssemblyToolPaths(). This eliminates the need for a static constructor whose sole purpose was to initialize this static field, addressing the code smell about unnecessary static constructors that only initialize static fields.

--- a/src/Cake.Common/Tools/Cake/CakeRunner.cs
+++ b/src/Cake.Common/Tools/Cake/CakeRunner.cs
@@ -29,1 +29,1 @@ namespace Cake.Common.Tools.Cake
-        private static readonly IEnumerable<FilePath> _executingAssemblyToolPaths;
+        private static readonly IEnumerable<FilePath> _executingAssemblyToolPaths = GetExecutingAssemblyToolPaths();

csharpsquid:S3963 - Initialize all 'static fields' inline and remove the 'static constructor'. • MINOR • View issue

Location: src/Cake.Common/Build/MyGet/MyGetProvider.cs:24

Why is this an issue?

When a static constructor serves no other purpose that initializing static fields, it comes with an unnecessary performance cost because the compiler generates a check before each static method or instance constructor invocation.

What changed

This hunk removes the static constructor and inlines the initialization of the _sanitizationTokens static field directly at its declaration. The static analysis rule flags static constructors that only initialize static fields, since they introduce unnecessary performance overhead (the compiler adds a beforefieldinit check before each static method or instance constructor call). By converting private static readonly Dictionary<string, string> _sanitizationTokens; with a separate static MyGetProvider() { _sanitizationTokens = new Dictionary<string, string> ... } into a single inline initialization private static readonly Dictionary<string, string> _sanitizationTokens = new Dictionary<string, string> ..., the static constructor is eliminated and the performance cost is avoided.

--- a/src/Cake.Common/Build/MyGet/MyGetProvider.cs
+++ b/src/Cake.Common/Build/MyGet/MyGetProvider.cs
@@ -21,6 +21,1 @@ namespace Cake.Common.Build.MyGet
-        private static readonly Dictionary<string, string> _sanitizationTokens;
-        private readonly ICakeEnvironment _environment;
-
-        static MyGetProvider()
-        {
-            _sanitizationTokens = new Dictionary<string, string>
+        private static readonly Dictionary<string, string> _sanitizationTokens = new Dictionary<string, string>

csharpsquid:S3963 - Initialize all 'static fields' inline and remove the 'static constructor'. • MINOR • View issue

Location: src/Cake.Common/Tools/Chocolatey/Pack/ChocolateyNuSpecTransformer.cs:21

Why is this an issue?

When a static constructor serves no other purpose that initializing static fields, it comes with an unnecessary performance cost because the compiler generates a check before each static method or instance constructor invocation.

What changed

This hunk removes the static constructor and the separate field declarations for _mappings and _cdataElements, replacing the _mappings field with an inline initialization. The static analysis warning flagged the static constructor as unnecessary since it only initializes static fields. By inlining the initialization of _mappings directly at the field declaration, this hunk eliminates part of the static constructor, addressing the performance cost associated with having a static constructor that only initializes static fields.

--- a/src/Cake.Common/Tools/Chocolatey/Pack/ChocolateyNuSpecTransformer.cs
+++ b/src/Cake.Common/Tools/Chocolatey/Pack/ChocolateyNuSpecTransformer.cs
@@ -18,6 +18,1 @@ namespace Cake.Common.Tools.Chocolatey.Pack
-        private static readonly Dictionary<string, Func<ChocolateyPackSettings, string>> _mappings;
-        private static readonly List<string> _cdataElements;
-
-        static ChocolateyNuSpecTransformer()
-        {
-            _mappings = new Dictionary<string, Func<ChocolateyPackSettings, string>>
+        private static readonly Dictionary<string, Func<ChocolateyPackSettings, string>> _mappings = new Dictionary<string, Func<ChocolateyPackSettings, string>>

csharpsquid:S3963 - Initialize all 'static fields' inline and remove the 'static constructor'. • MINOR • View issue

Location: src/Cake.Common/Tools/NuGet/Pack/NuspecTransformer.cs:21

Why is this an issue?

When a static constructor serves no other purpose that initializing static fields, it comes with an unnecessary performance cost because the compiler generates a check before each static method or instance constructor invocation.

What changed

This hunk removes the static constructor and the separate field declarations for _mappings and _cdataElements, replacing the _mappings field with an inline initialization. The static analysis rule flags static constructors that only initialize static fields, recommending inline initialization instead to avoid the performance cost of compiler-generated checks before each static method or instance constructor invocation. By converting _mappings from being assigned in the static constructor to being initialized inline at declaration, this hunk directly addresses the recommendation to remove the static constructor.

--- a/src/Cake.Common/Tools/NuGet/Pack/NuspecTransformer.cs
+++ b/src/Cake.Common/Tools/NuGet/Pack/NuspecTransformer.cs
@@ -18,6 +18,1 @@ namespace Cake.Common.Tools.NuGet.Pack
-        private static readonly Dictionary<string, Func<NuGetPackSettings, string>> _mappings;
-        private static readonly List<string> _cdataElements;
-
-        static NuspecTransformer()
-        {
-            _mappings = new Dictionary<string, Func<NuGetPackSettings, string>>
+        private static readonly Dictionary<string, Func<NuGetPackSettings, string>> _mappings = new Dictionary<string, Func<NuGetPackSettings, string>>

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud