fix: add assertion to ParallelCakeEngineTests.Should_Swallow_Exceptions_If_ContinueOnError_Is_Set

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Added an assertion to verify that no exception is thrown when ContinueOnError is set, fixing a SonarQube blocker issue that required all test cases to contain at least one assertion. This ensures the test properly validates the expected behavior of exception swallowing.

View Project in SonarCloud

---

Fixed Issues

csharpsquid:S2699 - Add at least one assertion to this test case. • BLOCKER • View issue

Location: src/Cake.Parallel.Tests/ParallelCakeEngineTests.cs:309

Why is this an issue?

The rule targets test methods that lack an assertion and consist solely of an action and, optionally, a setup.

What changed

This hunk fixes the test method 'Should_Swallow_Exceptions_If_ContinueOnError_Is_Set' which previously had no assertions. The original code simply called await engine.RunTargetAsync(...) without verifying any behavior. The fix wraps the call in Record.ExceptionAsync to capture any thrown exception, and then adds Assert.Null(record) to explicitly assert that no exception was thrown. This satisfies the static analysis rule requiring at least one assertion in every test method, ensuring the test meaningfully validates that exceptions are swallowed when ContinueOnError is set.

--- a/src/Cake.Parallel.Tests/ParallelCakeEngineTests.cs
+++ b/src/Cake.Parallel.Tests/ParallelCakeEngineTests.cs
@@ -316,2 +316,6 @@ namespace Cake.Parallel.Tests
-                // When, Then
-                await engine.RunTargetAsync(fixture.Context, fixture.ExecutionStrategy, "A");
+                // When
+                var record = await Record.ExceptionAsync(async () =>
+                    await engine.RunTargetAsync(fixture.Context, fixture.ExecutionStrategy, "A"));
+
+                // Then
+                Assert.Null(record);

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud