fix: resolve 4 SonarQube code quality issues

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Removed commented-out code, added exception handling explanation, and made utility class static. These changes address code smells that reduce maintainability and clarify developer intent without altering functionality.

View Project in SonarCloud

---

Fixed Issues

csharpsquid:S125 - Remove this commented out code. • MAJOR • View issue

Location: src/Cake.Parallel/ParallelGraphExtensions.cs:54

Why is this an issue?

Commented-out code distracts the focus from the actual executed code. It creates a noise that increases maintenance code. And because it is never executed, it quickly becomes out of date and invalid.

What changed

This hunk removes the commented-out line of code // await executeTask(nodeName, cancellationTokenSource).ConfigureAwait(false); from ParallelGraphExtensions.cs at line 54. The static analysis rule flags commented-out code as a code smell because it creates noise, distracts from actual executed code, and quickly becomes outdated. By replacing the commented-out code with blank lines, the hunk eliminates this code smell.

--- a/src/Cake.Parallel/ParallelGraphExtensions.cs
+++ b/src/Cake.Parallel/ParallelGraphExtensions.cs
@@ -54,1 +54,1 @@ namespace Cake.Parallel.Module
-            // await executeTask(nodeName, cancellationTokenSource).ConfigureAwait(false);
+

csharpsquid:S2486 - Handle the exception or explain in a comment why it can be ignored. • MINOR • View issue

Location: src/Cake.Parallel/ParallelCakeEngine.cs:299

Why is this an issue?

When exceptions occur, it is usually a bad idea to simply ignore them. Instead, it is better to handle them properly, or at least to log them.

What changed

This hunk adds a comment inside the previously empty catch block. The original code had a bare catch { } with no content, which triggered two static analysis warnings: one about swallowing exceptions without handling or explaining them (the generic exception suppression rule), and one about having an empty code block (which is confusing to maintainers). By adding the comment // Intentionally suppressed: if error reporting itself fails, there is nothing more we can do., both issues are resolved — the catch block is no longer empty (satisfying the empty block rule), and the exception suppression is explicitly explained in a comment (satisfying the exception handling rule, which has an exception for blocks containing comments).

--- a/src/Cake.Parallel/ParallelCakeEngine.cs
+++ b/src/Cake.Parallel/ParallelCakeEngine.cs
@@ -299,1 +299,4 @@ namespace Cake.Parallel.Module
-            catch { }
+            catch
+            {
+                // Intentionally suppressed: if error reporting itself fails, there is nothing more we can do.
+            }

csharpsquid:S108 - Either remove or fill this block of code. • MAJOR • View issue

Location: src/Cake.Parallel/ParallelCakeEngine.cs:299

Why is this an issue?

An empty code block is confusing. It will require some effort from maintainers to determine if it is intentional or indicates the implementation is incomplete.

What changed

This hunk adds a comment inside the previously empty catch block. The original code had a bare catch { } with no content, which triggered two static analysis warnings: one about swallowing exceptions without handling or explaining them (the generic exception suppression rule), and one about having an empty code block (which is confusing to maintainers). By adding the comment // Intentionally suppressed: if error reporting itself fails, there is nothing more we can do., both issues are resolved — the catch block is no longer empty (satisfying the empty block rule), and the exception suppression is explicitly explained in a comment (satisfying the exception handling rule, which has an exception for blocks containing comments).

--- a/src/Cake.Parallel/ParallelCakeEngine.cs
+++ b/src/Cake.Parallel/ParallelCakeEngine.cs
@@ -299,1 +299,4 @@ namespace Cake.Parallel.Module
-            catch { }
+            catch
+            {
+                // Intentionally suppressed: if error reporting itself fails, there is nothing more we can do.
+            }

csharpsquid:S1118 - Add a 'protected' constructor or the 'static' keyword to the class declaration. • MAJOR • View issue

Location: src/Cake.Parallel/ParallelGraphBuilder.cs:11

Why is this an issue?

Whenever there are portions of code that are duplicated and do not depend on the state of their container class, they can be centralized inside a "utility class". A utility class is a class that only has static members, hence it should not be instantiated.

What changed

This hunk adds the 'static' keyword to the ParallelGraphBuilder class declaration, changing it from 'public class' to 'public static class'. The static analysis warning flagged this class as a utility class (containing only static members) that could be instantiated despite having no reason to be. By marking the class as 'static', the compiler enforces that it cannot be instantiated, which is the correct pattern for utility classes and resolves the code smell.

--- a/src/Cake.Parallel/ParallelGraphBuilder.cs
+++ b/src/Cake.Parallel/ParallelGraphBuilder.cs
@@ -11,1 +11,1 @@ namespace Cake.Parallel.Module
-    public class ParallelGraphBuilder
+    public static class ParallelGraphBuilder

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqubecloud]

Quality Gate failed

Failed conditions
5 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE