Update testing framework and dependencies#318
Conversation
…test command to bun
…ng in createDebouncedSignal
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the testing framework and dependencies to enhance project maintainability and reliability. By migrating to Bun and updating dependencies, the project benefits from improved performance and access to the latest features. The addition of unit tests for Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. From Jest to Bun, a swift migration, New tests arise, an affirmation. Signals persist, Bugs now resist, A modern build, a clean creation. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request primarily migrates the project's testing framework from Jest to Bun's native test runner, involving the removal of Jest-related dependencies and configuration files, updating package.json scripts to use bun test, and adjusting test file imports from @jest/globals to bun:test. Additionally, it updates various @alwatr/* and @lerna-lite/* dependencies across the monorepo, removes a Copilot instruction file, and adds a JavaScript formatter setting to VS Code. A critical issue was identified where the lint:es script was disabled and ESLint dependencies removed, which needs to be addressed to maintain code quality. Another issue noted is the presence of it.only in a test file, which should be reverted to it to ensure all tests run.
…package.json and bun.lock
…, and signal packages
…, and signal packages
Description
Migrate the testing framework from Jest to Bun, updating relevant imports and configurations. Update various dependencies to their latest versions and streamline the test command in the build workflow. Additionally, enhance test coverage with new unit tests for the
PersistentStateSignalfunctionality. Clean up unused configurations and files to improve project maintainability.