Fix subsequence-based unambiguous completion - #576
Open
MahdiNazemi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
matcher-listenables subsequence matching, zsh can compute acompstate[unambiguous]value that is not a contiguous substring of every candidate. fzf-tab currently trusts that value and inserts it, which can bias completion toward one candidate instead of showing the fzf menu.This change validates the unambiguous insertion against the captured completion words first. If the proposed insertion is not contiguous in every matched word, fzf-tab falls through to the normal fzf candidate list.
Closes #560.
Tests
zsh -n fzf-tab.zsh test/fzftab.ztst test/runtests.zsh test/comptestcd test && zsh runtests.zsh fzftab.ztstsomedir/k_1234, and passes with this patch by showing both candidates.