Skip to content

Reset prompt after completion done - #426

Open
hotpxl wants to merge 2 commits into
Aloxaf:masterfrom
hotpxl:reset-prompt
Open

Reset prompt after completion done#426
hotpxl wants to merge 2 commits into
Aloxaf:masterfrom
hotpxl:reset-prompt

Conversation

@hotpxl

@hotpxl hotpxl commented Apr 2, 2024

Copy link
Copy Markdown

Somehow if I don't call zle reset-prompt, the highlighting turns off when the completion is done (either there's no more choice or when I ctrl-c)

@hotpxl

hotpxl commented Apr 4, 2024

Copy link
Copy Markdown
Author

Actually, it also works if I call zle redisplay instead of zle .redisplay (which seems like a cleaner solution).
Is there any reason we are calling the original .redisplay function? In my case, I use z-sy-h and it overrides widgets to highlight stuff.

@hotpxl

hotpxl commented Apr 9, 2024

Copy link
Copy Markdown
Author

@Aloxaf any comment is much appreciated!

@Aloxaf

Aloxaf commented Apr 24, 2024

Copy link
Copy Markdown
Owner

What is your plugin loading order? Did you make sure fzf-tab was loaded before z-sy-h?

@hotpxl

hotpxl commented Apr 24, 2024

Copy link
Copy Markdown
Author

yeah, fzf-tab is loaded before z-sy-h

@Aloxaf

Aloxaf commented Apr 25, 2024

Copy link
Copy Markdown
Owner

what's the output of echo $widgets[fzf-tab-complete]?

@hotpxl

hotpxl commented Apr 25, 2024

Copy link
Copy Markdown
Author
echo $widgets[fzf-tab-complete]
user:_zsh_autosuggest_bound_1_fzf-tab-complete

it's rebound by https://github.com/zsh-users/zsh-autosuggestions

@Aloxaf

Aloxaf commented Apr 26, 2024

Copy link
Copy Markdown
Owner

can you remove zsh-autosuggestions and try again?

@hotpxl

hotpxl commented Apr 29, 2024

Copy link
Copy Markdown
Author

I removed zsh-autosuggestions, the problem persists. And now

echo $widgets[fzf-tab-complete]
user:_zsh_highlight_widget_orig-s0.0000010000-r30869-fzf-tab-complete

@hotpxl

hotpxl commented Sep 4, 2024

Copy link
Copy Markdown
Author

hi, shall we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants