Skip to content

fix multiline prompt - #236

Open
qchateau wants to merge 1 commit into
Aloxaf:masterfrom
qchateau:master
Open

fix multiline prompt#236
qchateau wants to merge 1 commit into
Aloxaf:masterfrom
qchateau:master

Conversation

@qchateau

@qchateau qchateau commented Nov 6, 2021

Copy link
Copy Markdown

Hi,

I don't know what I'm doing, but I know it fixes my problem.
I'm using oh-my-zsh with p10k and a multi-line prompt. The multi-line seems to break fzf-tab,with my prompt scrolling up everytime I press tab and there no completion, and everytime I press '/' for continuous completion.

I have no idea whether this PR would break other users but I'll keep using it in my fork since I need it. So better open a PR and share it

@Aloxaf

Aloxaf commented Nov 30, 2021

Copy link
Copy Markdown
Owner

I also use multiline prompt.

Are you using custom fzf-command? Can your provide a minimal zshrc to reproduce this bug?

@gitaarik

gitaarik commented May 12, 2022

Copy link
Copy Markdown

I also have this issue on oh-my-zsh, and when removing the fzf-tab plugin the issue disappeared. However, I found out later, after some debugging, that the issue also disappeared when I removed COMPLETION_WAITING_DOTS="true" and kept the fzf-tab plugin. So it seems this option and fzf-tab don't work together well.

adam-ja added a commit to adam-ja/dotfiles that referenced this pull request Jan 19, 2023
This conflicts with the fzf-tab plugin causing the prompt to scroll up
unexpectedly (see Aloxaf/fzf-tab#236)
@exzombie

Copy link
Copy Markdown

I have the same problem; for me, disabling the waiting dots is not a good solution because I often deal with slow mounts and I find the visual indication very useful. @Aloxaf, is the workaround proposed in this PS something that can break other stuff? I'm not sufficiently familiar with the completion system to judge for myself.

@glasser

glasser commented Sep 27, 2024

Copy link
Copy Markdown

I see this too with fzf-tab and starship for my multi-line prompt. Removing COMPLETION_WAITING_DOTS="true" does fix it.

@doubleyewdee

Copy link
Copy Markdown

Same peculiar behavior for me (using starship instead of pl10k, but the problem was identical w/ pl10k as I recall), and confirmed that just not setting $COMPLETION_WAITING_DOTS resolves it. Has been bugging me for years. Maybe worth a note in docs if the PR above is not considered safe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants