fixed bug in make_array_dataloader#497
Merged
Merged
Conversation
…o pass array, list of arrays, or list of dict of arrays through the `data` argument
Contributor
Author
|
Alright, thanks for your help troubleshooting CytoDL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
make_array_dataloaderwould throw an error when trying to pass array, list of arrays, or list of dict of arrays through thedataargument. The solution (found with @fatwir) was to only performOmegaConf.to_object(data)ifdatawas a config, and not if it was an array / list of arrays / etc.I don't think that this change should have any breaking changes, as the original code was essentially converting a config object to a dict, and was not checking that it was actually taking in a config object.
Before submitting
pytestcommand?pre-commit run -acommand?