Skip to content

fixed bug in make_array_dataloader#497

Merged
SergeEParent merged 1 commit into
mainfrom
bugfix/make_array_dataloader
Aug 25, 2025
Merged

fixed bug in make_array_dataloader#497
SergeEParent merged 1 commit into
mainfrom
bugfix/make_array_dataloader

Conversation

@SergeEParent

Copy link
Copy Markdown
Contributor

What does this PR do?

make_array_dataloader would throw an error when trying to pass array, list of arrays, or list of dict of arrays through the data argument. The solution (found with @fatwir) was to only perform OmegaConf.to_object(data) if data was a config, and not if it was an array / list of arrays / etc.
I don't think that this change should have any breaking changes, as the original code was essentially converting a config object to a dict, and was not checking that it was actually taking in a config object.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?
    • I only ran pre-commit on the file I modified

…o pass array, list of arrays, or list of dict of arrays through the `data` argument
@SergeEParent
SergeEParent requested a review from fatwir August 25, 2025 20:09

@fatwir fatwir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SergeEParent

Copy link
Copy Markdown
Contributor Author

Alright, thanks for your help troubleshooting CytoDL!

@SergeEParent
SergeEParent merged commit 0df4443 into main Aug 25, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants