add/remove break windows on display change#160
Draft
AllanChain wants to merge 2 commits into
Draft
Conversation
The progress bar was driven by a long-running QPropertyAnimation started in the constructor, which was then scrubbed via setCurrentTime() in setTime(). This design was fragile: setCurrentTime() does not update the animated property when the animation is Stopped, and the animation stops when it reaches its end. During initial break window creation, remainingTime defaulted to 0, so setTime(0, ...) pushed the animation to its end, permanently freezing the progress bar at 0 (invisible with transparent background). Hot-plugged displays worked only because setTime() was called with a real remaining time while the animation was still running. Redesign setTime() as the single source of truth: each call starts a short 1-second interpolating animation from the bar's current value to the new target, giving smooth sub-second motion without long-running state that can desync. Also initialize remainingTime to the full break duration in create() so freshly created windows don't get setTime(0) before the real time is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.