This repository was archived by the owner on Oct 30, 2025. It is now read-only.
时间线中的手动置顶#46
Draft
Yixuan-Wang wants to merge 6 commits into
Draft
Conversation
Collaborator
Author
|
目前的错误处理方式是弹窗警告,似乎还需要改善。 |
AllanChain
reviewed
Aug 26, 2020
AllanChain
reviewed
Aug 26, 2020
AllanChain
reviewed
Aug 26, 2020
Collaborator
Author
好像不行,那样时间线就加载不出来了,整条 Promise 链都 reject 了…… |
- check error message before removing pinned - refactored title to Flow
Owner
所以应该判断错误信息。可能的情况是网不好,加载第一页的时候成功了,但是加载置顶洞的时候断网了,那么置顶洞会丢失。可以通过调成 slow 3G, 再调成 offline 复现。丢数据的事情应该尽量避免发生。 以及边循环边删会导致混乱(漏循环) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
可以在边栏中设置、取消,也可以在设置中调整。