Skip to content

fix modium-ore mining tags#203

Merged
thevortex merged 1 commit into
AllTheMods:26.1from
Satherov:26.1
Apr 20, 2026
Merged

fix modium-ore mining tags#203
thevortex merged 1 commit into
AllTheMods:26.1from
Satherov:26.1

Conversation

@Satherov

@Satherov Satherov commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

fixes the two incorrect tags causing vibranium ore and unobtanium ore to not be mineable

Resolves AllTheMods/ATM-11#18

@thevortex

Copy link
Copy Markdown
Contributor

any ideas why the mining dim is 95% empty and 0 oregen happens in the other? i saw some code in ATO that looked like it supports it but datagen doesnt seem to cover it

@Satherov

Satherov commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

any ideas why the mining dim is 95% empty and 0 oregen happens in the other? i saw some code in ATO that looked like it supports it but datagen doesnt seem to cover it

The mining dimension doesn't look that empty in dev if you take out a chunk but maybe the upper layers make it seem worse? or is it much more empty in ATM11 than here? The other being empty is an oversight from when I added ATM compat, I'll fix it in a second (fix here AllTheMods/AllTheOres#111)

image

@Satherov

Copy link
Copy Markdown
Contributor Author

ATM11 looks pretty equal. if it's too little do you want me to just increase the spawn count in the upper layers?

image

@thevortex thevortex merged commit 1bca5a2 into AllTheMods:26.1 Apr 20, 2026
1 check failed
@thevortex

Copy link
Copy Markdown
Contributor

a little bit i guess, the stone and deepslate layers were way too sparse when i tested

@Satherov

Copy link
Copy Markdown
Contributor Author

a little bit i guess, the stone and deepslate layers were way too sparse when i tested

I do have a changed version (which also adds the missing vanilla ores) but that may already be slightly overkill. It's quite packed now, especially the vanilla ores now add even more spawns. If you say that's fine I can pr right now, otherwise I'll play with the numbers a bit more

image image

@thevortex

Copy link
Copy Markdown
Contributor

either is good , if you want to scale it down just a bit thats fine but i was making it to deepslate digging down without seeing anything before

@Satherov

Copy link
Copy Markdown
Contributor Author

I'll leave it how it is then and if you later think it's too much the number can still be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants