support local compilation cache in disc backend#20
Open
Yancey0623 wants to merge 4 commits into
Open
Conversation
anw90
reviewed
Nov 11, 2024
anw90
left a comment
anw90
left a comment
There was a problem hiding this comment.
Please add some ut for this pr to check if the caching works
| for (auto device : computation->devices()) { | ||
| result_pb.add_devices(device); | ||
| } | ||
| return hlo_proto.SerializeAsString() + ":::" + result_pb.SerializeAsString(); |
There was a problem hiding this comment.
Maybe we could use absl::strcat to concat the strings.
| res.inputs = inputs; | ||
| res.outputs = outputs; | ||
|
|
||
| DISCCompileResult result; |
| int DISCComputationClient::GetProcessIndex() const { return local_rank_; } | ||
|
|
||
| int DISCComputationClient::GetNumProcesses() const { return world_size_; } | ||
| std::string DISCComputationClient::SerializeComputation( |
Yancey0623
force-pushed
the
disc_cache
branch
from
f22e15d to
9913ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support compilation result Serialize and Deserialize.