fix qwen-vl failed with FSDP#30
Open
Yancey0623 wants to merge 4 commits into
Open
Conversation
yitongh
reviewed
Nov 6, 2024
yitongh
reviewed
Nov 11, 2024
yitongh
left a comment
yitongh
left a comment
Contributor
There was a problem hiding this comment.
Should we also change the self.model to self._module in fsdp.py, spmd_fsdp.py, pp/pipeline.py, dp.py
Author
@yitongh good idea, I will do that in the next PR. |
yitongh
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR search attribute from the original module if the attribute is missing in the FSDP wrapper module.