Add Scottish Water support to downstream impact pipeline and data docs#42
Conversation
Agent-Logs-Url: https://github.com/AlexLipp/sewage-map/sessions/7238a0fa-845b-4a71-a7d1-5baadfa8291f Co-authored-by: AlexLipp <10188895+AlexLipp@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AlexLipp/sewage-map/sessions/7238a0fa-845b-4a71-a7d1-5baadfa8291f Co-authored-by: AlexLipp <10188895+AlexLipp@users.noreply.github.com>
|
@copilot Just noticed that Thames Water is not referenced as a data source in the readme (https://data.thameswater.co.uk/s/). They maintain their own API like Scottish Water. Can you fix this please? |
Agent-Logs-Url: https://github.com/AlexLipp/sewage-map/sessions/d21fb122-fcc5-4c20-9a9c-fcd1dbc05b50 Co-authored-by: AlexLipp <10188895+AlexLipp@users.noreply.github.com>
Done in commit |
There was a problem hiding this comment.
Pull request overview
Adds Scottish Water to the downstream impact publishing workflow and updates README dataset links/source attribution to include Scottish outputs.
Changes:
- Wired
scottishintoupdate_downstream.py(company list +ScottishWater()instantiation). - Expanded README scope statement to include Scotland and added Scottish Water output links.
- Updated README source attribution to include the Scottish Water overflow open data link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
update_downstream.py |
Adds Scottish Water to downstream processing and output publishing under downstream_impact/scottish/. |
README.md |
Documents Scottish Water outputs/links and updates scope + source attribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from poopy.companies import ( | ||
| AnglianWater, | ||
| NorthumbrianWater, | ||
| ScottishWater, | ||
| SevernTrentWater, |
There was a problem hiding this comment.
update_downstream.py imports ScottishWater from the external poopy package, but this repo doesn't appear to pin/document a minimum POOPy version. This can cause the cron job to fail at import time on environments still running an older POOPy. Consider adding explicit dependency/version pinning (requirements/pyproject) or at least documenting the required POOPy version and failing with a clearer message if the import isn't available.
|
|
||
|
|
||
| Realtime mapping the downstream impact of Combined Sewage Overflow discharge events in non-tidal rivers across England <!--and Wales-->. This repository provides the back-end for [`www.sewagemap.co.uk`](https://www.sewagemap.co.uk/). The repository for the front-end is available at [`github.com/JonnyDawe/UK-Sewage-Map/`](https://github.com/JonnyDawe/UK-Sewage-Map/). | ||
| Realtime mapping the downstream impact of Combined Sewage Overflow discharge events in non-tidal rivers across England and Scotland <!--and Wales-->. This repository provides the back-end for [`www.sewagemap.co.uk`](https://www.sewagemap.co.uk/). The repository for the front-end is available at [`github.com/JonnyDawe/UK-Sewage-Map/`](https://github.com/JonnyDawe/UK-Sewage-Map/). |
There was a problem hiding this comment.
This sentence updates the scope to "England and Scotland", but the README title/subtitle at the top still says the project maps discharges across England (and has a commented Wales note). Consider updating the earlier line(s) too so the README scope is consistent throughout.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
|
Approve |
This PR adds Scottish Water to the downstream impact workflow using the new
poopy.companies.ScottishWaterintegration and updates public documentation to include Scottish outputs and source attribution. It keeps Thames historical handling unchanged (Scottish data is current-only).Downstream processing: wire in Scottish Water
ScottishWaterimport toupdate_downstream.pyscottishto the company processing listscottish -> ScottishWater()downstream_impact/scottish/path with existing filename conventionsREADME: expand published datasets
downstream_impact/scottish/README: source attribution
https://www.scottishwater.co.uk/Help-and-Resources/Open-Data/Overflow-Map-DataExample integration change: