Remove depreciated login components#84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated login/account-management functionality from the client runtime, introduces a new runtime.js entrypoint for the practice flow, and updates the build/service-worker tooling (Workbox config rename + esbuild-based minification) to match the simplified app.
Changes:
- Removed legacy login/account UI/scripts and switched the runtime page to load
runtime.min.js. - Renamed Workbox config to
workbox-config.cjsand updated thenpm run workboxscript accordingly. - Added an
esbuild-poweredminifyscript and refreshed generated service worker assets; updated docs and Sentry CDN versions.
Reviewed changes
Copilot reviewed 19 out of 25 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| workbox-config.js | Removed legacy Workbox config (replaced by .cjs). |
| workbox-config.cjs | New Workbox config file used by CLI. |
| package.json | Adds minify script, switches Workbox CLI to use .cjs, adds esbuild. |
| package-lock.json | Locks esbuild and platform binaries. |
| index.html | Updates Sentry browser bundle URLs/integrity. |
| docs/index.md | Updates runtime/login script references and account-management notes. |
| docs/guides/setup.md | Updates script references and build instructions. |
| docs/guides/marking-algorithm.md | Removes account-management-specific threshold docs. |
| docs/guides/data-structures.md | Updates runtime script references. |
| docs/architecture/index.md | Updates runtime script references and system description. |
| docs/api/index.md | Updates “Called By” reference to runtime.js. |
| core/systemrun.html | Removes login/account UI + scripts; loads runtime.min.js; updates Sentry bundles. |
| core/scripts/serviceWorker/workbox-813eeb66.js | New generated Workbox runtime chunk. |
| core/scripts/serviceWorker/sw.js | Updated generated service worker precache manifest + runtime caching. |
| core/scripts/serviceWorker/sw.js.map | Updated service worker source map output. |
| core/scripts/runtime.js | New runtime/practice flow entrypoint (replaces login bootstrap). |
| core/scripts/runtime.min.js | Minified runtime bundle output. |
| core/scripts/runtime.test.js | Adds Jest tests (currently focused on threshold logic). |
| core/scripts/login.js | Deleted legacy login/registration logic. |
| core/scripts/login.min.js | Deleted legacy minified login bundle. |
| core/scripts/login.test.js | Deleted legacy login tests. |
| core/scripts/crispr_scripts.js | Removes account-management code; factors out off-target threshold helper. |
| core/scripts/crispr_scripts.min.js | Updated minified output matching new logic. |
| .prettierignore | Ignores workbox-config.cjs instead of removed .js. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove depreciated login components. Also added support for esbuild for auto-minification.