Setup Playwright e2e testing#63
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets up Playwright end-to-end testing infrastructure for the SciGrade application, including accessibility testing capabilities using axe-playwright. The changes integrate Playwright tests into the validation workflow and improve HTML semantic structure for better accessibility.
- Adds comprehensive Playwright configuration with multi-browser and device testing
- Implements accessibility testing utilities with axe-playwright integration
- Creates initial homepage e2e tests with automated accessibility checks
- Updates build pipeline to include Playwright tests in validation
Reviewed Changes
Copilot reviewed 11 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.js | Comprehensive test configuration with multi-browser/device support and webServer setup |
| tests/playwright/utils/base.js | Base test utilities for extended Playwright functionality |
| tests/playwright/utils/accessibility.js | Accessibility testing helper using axe-playwright |
| tests/playwright/homepage.spec.js | Homepage e2e tests with accessibility validation |
| package.json | Added Playwright dependencies and test scripts |
| jest.config.mjs | Updated test paths and patterns for better separation |
| eslint.config.js | Added Playwright-specific ESLint configuration |
| core/systemrun.html | Improved semantic HTML structure with proper navigation elements |
| core/scripts/login.js | Added accessibility label to gene dropdown |
| core/scripts/crispr_scripts.js | Variable naming consistency and accessibility improvements |
| .github/workflows/code-qa.yaml | Integrated Playwright tests into CI pipeline |
Comments suppressed due to low confidence (1)
core/scripts/crispr_scripts.js:1
- Corrected spelling of 'aira-label' to 'aria-label'.
/* eslint-disable indent */
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.