Add initial Windows compatibility fixes#7
Open
quilmach wants to merge 1 commit into
Open
Conversation
Author
|
I tested the current upstream build using the new static workflow (make build-static, make serve-static) and verified that the Windows compatibility fixes still work correctly with Poppler and Tesseract on PATH. Let me know if you would like any adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues encountered when running Unredact on Windows.
Changes include:
Fixes to dictionary loading in pipeline/dictionary.py
Adjustments in pipeline/font_detect.py
Fixes in pipeline/ocr.py related to Windows path handling
General compatibility fixes so the server runs correctly on Windows with Poppler and Tesseract installed in PATH
Notes from testing:
While running on Windows, the Rust solver required the data directory to be present under solver_rs/ for the application to work correctly. I did not include this change in the commit because it may be a packaging issue, but documenting it here in case it helps debugging.
Tested on:
Windows 11
Python 3.12
Poppler installed via winget
Tesseract installed and available in PATH