331 feat adding spearman pitch control#362
Conversation
This is the first implementation of the pitch control suggested by Spearman(2017). It should work, but there are still a lot of things to be done, like mathematical refinement and also making the code more efficient
The calculation of the pitch control was changed to be more true to the original intent of spearman.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (13.04%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #362 +/- ##
===========================================
- Coverage 99.22% 97.41% -1.82%
===========================================
Files 49 67 +18
Lines 3736 5291 +1555
===========================================
+ Hits 3707 5154 +1447
- Misses 29 137 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @twar-TuVie, Thanks for opening the first implementation of the pitch control! I have a few points that relate to performance for now:
These are just some first observations. A few questions to make this more productive:
The CI test are failing because the code is not formatted the way it should be. runn the following commands to fix the linters: poetry run ruff format tests/ databallpy/
poetry run ruff check --fix tests/ databallpy/ |
First implementation of pitch control model after Spearman(2017)