RC #336

[jordanjones243]

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Review Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

RC Checklist

Testing Checklist:

Browsers

Browsers Support Guide

Dev demo link

Android

• Chrome - @jordanjones243
• Firefox - @jordanjones243

iOS

• Chrome - @jordanjones243
• Firefox - @jordanjones243
• Safari - @jordanjones243

Desktop

• Chrome - @jordanjones243
• Firefox - @jordanjones243
• Safari - @jordanjones243
• Edge - @jordanjones243

Scenarios

• Validated linked issues with issue reporting team - @jason-capsule42
• Test coverage report review - @jordanjones243

Framework playground

• Next React - @jordanjones243
• SvelteKit - @jordanjones243

**By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.**

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Remove deprecated ARIA pressed state handling from auro-hyperlink button usage and adjust layout and tests accordingly.

Bug Fixes:

• Relax href assertion in tests to account for dynamic localhost ports when resolving relative URLs.

Enhancements:

• Simplify auro-hyperlink button semantics by removing internal aria-pressed state management and related attributes.
• Update hyperlink styles so inline variants use flex layout and align embedded auro-icon elements visually.

Documentation:

• Clarify documentation for role="button" usage by removing mention of automatic aria-pressed state tracking.

Tests:

• Update auro-hyperlink tests to reflect removal of aria-pressed attribute on button-role links and to validate href resolution via a regex rather than a fixed absolute URL.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes aria-pressed handling from auro-hyperlink button-mode behavior, updates tests and documentation accordingly, relaxes a brittle href test to account for dynamic localhost ports, and tweaks styling for inline hyperlinks and embedded icons.

Updated class diagram for ComponentBase and AuroHyperlink aria-pressed removal

classDiagram
  class ComponentBase_before {
    -defaultReferrerPolicy string
    -ariapressed string
    -hyperlinkRef
    +ariaPressedState(ariaPressed boolean) boolean
    +render()
  }

  class ComponentBase_after {
    -defaultReferrerPolicy string
    -hyperlinkRef
    +render()
  }

  class AuroHyperlink_before {
    +render()
    +template_includes_aria_pressed_binding_for_button_role()
  }

  class AuroHyperlink_after {
    +render()
    +template_omits_aria_pressed_binding_for_button_role()
  }

  ComponentBase_before <|-- AuroHyperlink_before
  ComponentBase_after <|-- AuroHyperlink_after

Loading

File-Level Changes

Change	Details	Files
Remove aria-pressed state management from the base component and auro-hyperlink rendering.	Delete the aria-pressed instance property from the ComponentBase constructor. Remove the ariaPressedState() method and its event listeners from ComponentBase. Stop rendering the aria-pressed attribute on the auro-hyperlink anchor element when role="button".	src/component-base.mjs src/auro-hyperlink.js
Align tests and documentation with the removal of aria-pressed handling and make the href test port-agnostic.	Update the button-role unit test to no longer expect aria-pressed="false" on the anchor element. Change the relative href test to assert using a regex that matches localhost with any port, instead of a fixed URL and attribute check. Update API docs to remove the statement that auro-hyperlink tracks aria-pressed when used as a button.	test/auro-hyperlink.test.js docs/partials/api.md
Adjust hyperlink layout and icon positioning for non-CTA/nav hyperlink types.	Change .hyperlink display from inline-block to flex for non-CTA/nav host types to better align content. Add positioning rules for [auro-icon] children to vertically align icons slightly using relative positioning and a 1px top offset.	src/styles/style.scss

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Removing the aria-pressed handling for role="button" hyperlinks changes the accessibility semantics; consider either justifying this change in the description (e.g., design/ARIA guidance) or replacing it with an alternative pattern (such as using aria-pressed only where a true toggle button is intended).
• Changing .hyperlink from display: inline-block to display: flex for non-CTA/nav links may impact existing layouts (line wrapping, alignment, etc.); consider whether inline-flex would better preserve prior behavior or explicitly validate how this affects typical embedding contexts.
• The absolute href assertion now uses a regex against anchor.href; you might consider using the URL constructor (e.g., new URL(anchor.href)) to assert specific parts like pathname or origin instead of a pattern match on the full string.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Removing the `aria-pressed` handling for `role="button"` hyperlinks changes the accessibility semantics; consider either justifying this change in the description (e.g., design/ARIA guidance) or replacing it with an alternative pattern (such as using `aria-pressed` only where a true toggle button is intended).
- Changing `.hyperlink` from `display: inline-block` to `display: flex` for non-CTA/nav links may impact existing layouts (line wrapping, alignment, etc.); consider whether `inline-flex` would better preserve prior behavior or explicitly validate how this affects typical embedding contexts.
- The absolute `href` assertion now uses a regex against `anchor.href`; you might consider using the `URL` constructor (e.g., `new URL(anchor.href)`) to assert specific parts like pathname or origin instead of a pattern match on the full string.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀